Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics diff error message in --no-scm projects #3650

Merged
merged 9 commits into from
Apr 21, 2020

Conversation

karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented Apr 19, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

I am not sure if there is any other scm tools besides git going to be supported.
If so, the error message"only supported for Git repositories" is not proper one,

fix #3605

@karajan1001 karajan1001 changed the title fix #3605 metrics diff error message in --no-scm projects Apr 19, 2020
@karajan1001
Copy link
Contributor Author

Updated, I found dvc metrics dfif raise this exception after I initialized a git repository.
This was because the dvc configuration do not updated.
And only with cmd dvc config core.no_scm False , it finally be solved.

dvc/scm/base.py Outdated Show resolved Hide resolved
@efiop
Copy link
Contributor

efiop commented Apr 20, 2020

@karajan1001 Btw, looks like your git email is not added to your github email list. Please go to https://github.com/settings/emails and make sure that your git email (you can see it in git log, not posting it myself so it is not picked up by bots) is added there. That way all of your contributions will be taken into account by github πŸ™‚

dvc/scm/base.py Outdated Show resolved Hide resolved
dvc/scm/base.py Outdated Show resolved Hide resolved
tests/func/test_metrics.py Outdated Show resolved Hide resolved
dvc/repo/brancher.py Outdated Show resolved Hide resolved
@efiop
Copy link
Contributor

efiop commented Apr 20, 2020

Sorry for the delay! Please take a look at a few comments above.

@jorgeorpinel
Copy link
Contributor

Resolved a few items related to the output string.

Co-Authored-By: Ruslan Kuprieiev <[email protected]>
@karajan1001
Copy link
Contributor Author

Resolved a few items related to the output string.

Thank you, I will solve other things after work.

karajan1001 and others added 3 commits April 21, 2020 20:20
`NoSCM` Object now raise `NoSCMError` when calling attributes which only in `Git` Object
Mail change test
@efiop
Copy link
Contributor

efiop commented Apr 21, 2020

Thank you @karajan1001 ! πŸŽ‰

@efiop efiop merged commit 254cf83 into iterative:master Apr 21, 2020
@karajan1001 karajan1001 deleted the 3605 branch April 7, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics diff: cryptic error in --no-scm projects [qa]
3 participants