stage: resolve stage path before creating the stage #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current logic is extremely complex and messy, hiding a lot of bugs inside. There are pretty much only 2 scenarios for stage creation: 1) `dvc add/import/etc` when dvcfile is created beside the output file 2) `dvc run` when dvcfile is created at the place of execution both are transparently affected by `--fname` flag. Since we've removed `--cwd` complexity already, there is no reason to generalize stage path resolution for those two scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic is extremely complex and messy, hiding a lot of bugs
inside. There are pretty much only 2 scenarios for stage creation:
dvc add/import/etcwhen dvcfile is created beside the output filedvc runwhen dvcfile is created at the place of executionboth are transparently affected by
--fnameflag. Since we've removed--cwdcomplexity already, there is no reason to generalize stage pathresolution for those two scenarios.
This is also useful in preparation for
dvcfile+Stagedecoupling.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏