remote: use progress bar for remote cache query status during dvc gc
#3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pmrowla
commented
Mar 31, 2020
Comment on lines
+138
to
+146
| def test_cache_checksums(): | ||
| remote = RemoteBASE(None, {}) | ||
| remote.path_info = PathInfo("foo") | ||
|
|
||
| with mock.patch.object( | ||
| remote, "list_cache_paths", return_value=["12/3456", "bar"] | ||
| ): | ||
| checksums = list(remote.cache_checksums()) | ||
| assert checksums == ["123456"] |
pmrowla
commented
Mar 31, 2020
Comment on lines
710
to
712
| logger.debug( | ||
| "'%s' doesn't look like a cache file, skipping", path | ||
| ) |
There was a problem hiding this comment.
This is makes push/pull/gc very verbose now to the point that I'm not sure it's worth logging?
...
2020-03-31 18:49:52,911 DEBUG: '/Users/pmrowla/git/remote-1m-files/.dvc/cache/c5/d84d5879b6266fe8624802e99ff211.dir.unpacked/000360c8.txt' doesn't look like a cache file, skipping
2020-03-31 18:49:52,935 DEBUG: '/Users/pmrowla/git/remote-1m-files/.dvc/cache/c5/d84d5879b6266fe8624802e99ff211.dir.unpacked/00001f77.txt' doesn't look like a cache file, skipping
2020-03-31 18:49:53,122 DEBUG: '/Users/pmrowla/git/remote-1m-files/.dvc/cache/c5/d84d5879b6266fe8624802e99ff211.dir.unpacked/000569a4.txt' doesn't look like a cache file, skipping
...
(it catches every unpacked file in local .dvc/cache)
Prior to #3557 this exception handler was just a pass in RemoteBASE.all()
pared
approved these changes
Apr 1, 2020
efiop
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
dvc gc -cnow uses the same behavior aspush/pullwhen fetching checksums from a remote cacheWill close #3543