Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote: use progress bar when paginating #3532

Merged
merged 7 commits into from
Mar 28, 2020
Merged

remote: use progress bar when paginating #3532

merged 7 commits into from
Mar 28, 2020

Commits on Mar 27, 2020

  1. remote: use progress bar when paginating 

    - add `progress_callback` parameter to `list_cache_paths()` so that
  remotes can update remote cache traverse progress bar after fetching a
  page
    @pmrowla
    pmrowla committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    48a8078 View commit details
    Browse the repository at this point in the history

  2. Show remote size estimation status as no-total progress bar

    @pmrowla
    pmrowla committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    1c73fe7 View commit details
    Browse the repository at this point in the history

  3. Update pbar per item rather than per page

    @pmrowla
    pmrowla committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d9ca41b View commit details
    Browse the repository at this point in the history

  4. make tests more explicit (don't use mock.ANY)

    @pmrowla
    pmrowla committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d84fd8c View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    minor fixes/tidy
    @casperdcl @pmrowla
    casperdcl authored and pmrowla committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    56c2942 View commit details
    Browse the repository at this point in the history

  6. Use progress_callback in ssh/local list_cache_paths() 

    - keep ssh/local consistent with other remotes (even though `dvc
  gc`/`RemoteBASE.all()` do not currently use progress bars)
    @pmrowla
    pmrowla committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    b200d7d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2020

  1. Fix review issues

    @pmrowla
    pmrowla committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    ba1dc78 View commit details
    Browse the repository at this point in the history