repo: Prevent repo from setting log level #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging base repo
|
Hi @gauravr ! Thanks for the PR! 🙏 We've merged a config refactor just a hour ago and it means that you will need to rebase your PR to solve conflicts. Could you please do that? The PR itself looks great! |
|
Hello @efiop ! I have resolved conflicts. Thank you. |
efiop
suggested changes
Feb 13, 2020
There was a problem hiding this comment.
Thanks! Need to also remove https://github.com/iterative/dvc/blob/master/dvc/config.py#L108 .
|
@efiop thank you for pointing that out. Removed loglevel schema. |
efiop
approved these changes
Feb 13, 2020
woodshop
added a commit
to woodshop/dvc.org
that referenced
this pull request
Apr 29, 2020
`core.loglevel` was removed from the available config options in iterative/dvc#3321. This PR updates the documentation to remove any references to the deprecated configuration setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in the Contributing to DVC list?
Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Fixes: #1952