Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger: refactor, remove dead code #3306

Merged
merged 1 commit into from Feb 17, 2020
Merged

logger: refactor, remove dead code #3306

merged 1 commit into from Feb 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2020 •
edited by ghost
Loading

This PR includes some modifications that I did way back but never pushed them, some problems where already addressed by #3290

  • Remove dead code
  • Rename _walk_exc to _causes, simplify it
  • Split up stack trace and remove extra \n
  • Import traceback only when needed
  • Add test exc_info in other levels

@ghost
Copy link
Author

ghost commented Feb 11, 2020 •
edited by ghost
Loading

uh, thought that I rebased master already...

UPDATE: done 👌

@ghost ghost requested a review from efiop February 11, 2020 18:40
efiop
efiop reviewed Feb 13, 2020
View reviewed changes
dvc/logger.py Outdated Show resolved Hide resolved
efiop
efiop reviewed Feb 13, 2020
View reviewed changes
dvc/logger.py Outdated Show resolved Hide resolved
efiop
efiop reviewed Feb 13, 2020
View reviewed changes
dvc/logger.py Outdated Show resolved Hide resolved
efiop
efiop reviewed Feb 13, 2020
View reviewed changes
dvc/logger.py Outdated Show resolved Hide resolved
logger: refactor, remove dead code
765c1fe 
* Remove dead code
* Rename _walk_exc to _causes, simplify it
* Split up stack trace and remove extra \n
* Import traceback only when needed
@ghost ghost requested a review from efiop February 14, 2020 20:02
@ghost
Copy link
Author

ghost commented Feb 14, 2020

Thanks, @efiop , changes addressed, would you mind reviewing it again?

@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
efiop
efiop approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 8492786 into iterative:master Feb 17, 2020
@ghost ghost deleted the tidy-up-logger branch February 22, 2020 20:45
@weekly-digest weekly-digest bot mentioned this pull request Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efiop