repro: fix bug in _get_active_graph #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record: Waiting for confirmation from the user. |
efiop
changed the title
efiop
commented
Feb 10, 2020
There was a problem hiding this comment.
No-target case needs re-consideration, as it will leave disconnected stages as a subgraph, which we don't actually want to reproduce. Looking into it.
EDIT: No, it doesn't, as we always require a target. Need to think about active_pipelines (e.g. --all-pipelines) after this patch though, as they will now see parts that were previously cut-off.
|
Original bug reporter here - I have tested this change in my repository, and it now works as expected. |
efiop
force-pushed
the
mdekstrand_bug
branch
from
ac0e4cb to
7070327
Compare
efiop
changed the title
efiop
force-pushed
the
mdekstrand_bug
branch
2 times, most recently
from
cb2634c to
bc6e346
Compare
We are currently removing all of the deps stages from the DAG even if those deps are referenced by some parallel branches of execution. The new approach is to remove edges and then gradually remove nodes if there are no more `in` edges left. Discord context: https://discordapp.com/channels/485586884165107732/485596304961962003/676464313942409265
efiop
force-pushed
the
mdekstrand_bug
branch
from
bc6e346 to
2999847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently removing all of the deps stages from the DAG even if
those deps are referenced by some parallel branches of execution.
The new approach is to remove edges and then gradually remove nodes if
there are no more
inedges left.Discord context:
https://discordapp.com/channels/485586884165107732/485596304961962003/676464313942409265
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏