-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDrive improvements and code cleanup #3294
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3294 +/- ##
=========================================
Coverage ? 92.83%
=========================================
Files ? 139
Lines ? 8541
Branches ? 0
=========================================
Hits ? 7929
Misses ? 612
Partials ? 0
Continue to review full report at Codecov.
|
@efiop I suggest we review codeclimate and deepsource settings a bit and make the more useful/less noisy for us. E.g. number of arguments per function - if we think that 4 is to aggressive let's increase it a bit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me! 👍
It's a major rewrite now. It was needed since it was very hard an unproductive fixing certain issues w/o addressing some underlying problems with code.
pull
- one API call per file less!Stop creating a path to the DVC remote root if it does not exist
checkbox) in Google Drive support further enhancements #2865❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏