Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GDrive code cleanup #3293

Closed
wants to merge 5 commits into from

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein commented Feb 10, 2020

  • Performance of remote id resolving improved. It does not hit API now for "remote path". Affects pull - one API call per file less!
  • Number of retries increased. The previous was not enough with default GDrive limits.
  • Does not create remote path anymore (see the Stop creating a path to the DVC remote root if it does not exist checkbox) in Google Drive support further enhancements #2865
  • Code cleanup.

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • 📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@shcheklein
Copy link
Member Author

@efiop @Maxris do I actually need to create a branch or copy the environment somehow to run the GDrive tests?

@shcheklein shcheklein requested review from maxhora and efiop February 10, 2020 01:12
@efiop
Copy link
Contributor

efiop commented Feb 10, 2020

@shcheklein Yes, only upstream branches have access to the gdrive keys. I remember @Maxris mentioned that you could push branch with the same name to upstream to make it run with secure keys, but I'm not sure if that still works these days. Give it a try, if it doesn't work - just re-create a PR from an upstream branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants