Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdrive: add gc command support #3288

Merged
merged 1 commit into from
Feb 9, 2020
Merged

gdrive: add gc command support #3288

merged 1 commit into from
Feb 9, 2020

Conversation

maxhora
Copy link
Contributor

@maxhora maxhora commented Feb 8, 2020

Implements RemoteGDrive.remove to support gc functionality.

Related to #2865

@maxhora maxhora self-assigned this Feb 8, 2020
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #3288 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3288      +/-   ##
==========================================
- Coverage   92.92%   92.56%   -0.36%     
==========================================
  Files         139      139              
  Lines        8493     8500       +7     
==========================================
- Hits         7892     7868      -24     
- Misses        601      632      +31     
Impacted Files Coverage Δ
dvc/system.py 78.07% <0.00%> (-9.65%) ⬇️
dvc/remote/ssh/connection.py 82.50% <0.00%> (-4.50%) ⬇️
dvc/remote/gdrive.py 85.57% <0.00%> (-3.98%) ⬇️
dvc/analytics.py 94.52% <0.00%> (-1.37%) ⬇️
dvc/updater.py 54.65% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b3297...bbd46fb. Read the comment docs.

@efiop
Copy link
Contributor

efiop commented Feb 9, 2020

@Maxris Please check the tests.

@maxhora
Copy link
Contributor Author

maxhora commented Feb 9, 2020

@efiop it seems the exceptions are related to recent changes in commit 19acded#diff-24be7b52326b428c2569724796020192

error in Travis logs - https://travis-ci.com/iterative/dvc/jobs/285154054#L17901

not sure why it fails randomly, but just restart of failed jobs helped to pass everything successfully

@efiop
Copy link
Contributor

efiop commented Feb 9, 2020

@Maxris Thanks for investigating! I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants