Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use helper remotes in external repro #3149

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jan 14, 2020

Last PR for #2878. Closes #2878

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@skshetry skshetry added refactoring Factoring and re-factoring testing Related to the tests and the testing infrastructure labels Jan 14, 2020
@skshetry skshetry requested a review from efiop January 14, 2020 17:48
@skshetry skshetry self-assigned this Jan 14, 2020
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 4278481 into iterative:master Jan 14, 2020
@skshetry skshetry deleted the refactor-remote branch January 14, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Factoring and re-factoring testing Related to the tests and the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor test/remotes.py by merging inside remote classes
2 participants