test: refactor ssh related functions in test helper classes #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Jan 13, 2020
Comment on lines
-117
to
-120
| def get_ssh_url(): | ||
| return "ssh://{}@127.0.0.1:22{}".format( | ||
| getpass.getuser(), get_local_storagepath() | ||
| ) |
There was a problem hiding this comment.
I did not find any usage of this, probably, because we are moving away from real server to mocked ssh server? Anyway, I didn't want to change this atm.
There was a problem hiding this comment.
@skshetry I think it is still used in tests/func/test_api.py . We are close to getting rid of it, that is true 🙂 Let's not tackle it in this PR though.
There was a problem hiding this comment.
Yep, it is still used in
Line 26 in 028d30e
I only grepped for the get_ssh_url/SSH.get_url and didn't find any. 🤦♂️
skshetry
commented
Jan 13, 2020
Comment on lines
+261
to
+270
| # NOTE: On Windows get_local_storagepath() will return an | ||
| # ntpath that looks something like `C:\some\path`, which is not | ||
| # compatible with SFTP paths [1], so we need to convert it to | ||
| # a proper posixpath. | ||
| # To do that, we should construct a posixpath that would be | ||
| # relative to the server's root. | ||
| # In our case our ssh server is running with `c:/` as a root, | ||
| # and our URL format requires absolute paths, so the | ||
| # resulting path would look like `/some/path`. | ||
| # |
There was a problem hiding this comment.
I splitted the comment here as it was getting more than 80chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2878
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏