Move fs utilities to fs.py from __init__.py #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@efiop I have initiated the shifting of filesystem utilities from |
Codecov Report
@@ Coverage Diff @@
## master #3093 +/- ##
==========================================
+ Coverage 90.07% 91.77% +1.69%
==========================================
Files 138 138
Lines 8535 8535
==========================================
+ Hits 7688 7833 +145
+ Misses 847 702 -145
Continue to review full report at Codecov.
|
|
@algomaster99 Thank you for the PR! π I think the only one that is left to move is |
algomaster99
changed the title
|
@efiop PR has been updated. Please see. Thanks! |
|
Thank you @algomaster99 ! π For the record: tests failing for unrelated reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Have you followed the guidelines in the Contributing to DVC list?
π Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
β Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. π
This pull request moves all fs utilities to
fs.pyfrom__init__.py.Fixes #2137