Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: merge _should_test_oss and _get_oss_url inside OSS test helper #3071

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jan 6, 2020

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Related to #2878

@skshetry skshetry changed the title test: merge _should_oss_azure and _get_oss_url inside OSS class test: merge _should_test_oss and _get_oss_url inside OSS class Jan 6, 2020
@skshetry skshetry changed the title test: merge _should_test_oss and _get_oss_url inside OSS class test: merge _should_test_oss and _get_oss_url inside OSS test helper Jan 6, 2020
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks!

@efiop efiop merged commit 0f08b7e into iterative:master Jan 6, 2020
@skshetry skshetry deleted the refactor-remote-oss branch January 7, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants