Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remote: local: migrate to dir fixtures #3049

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

pared
Copy link
Contributor

@pared pared commented Jan 3, 2020

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@pared pared force-pushed the 2896_remote_local branch from f9b3097 to ce0eb08 Compare January 4, 2020 01:48
@pared pared requested a review from efiop January 4, 2020 01:48
@efiop efiop requested review from Suor and a user January 4, 2020 03:27
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, @pared

@efiop efiop merged commit 7f92cc3 into iterative:master Jan 5, 2020
@pared pared deleted the 2896_remote_local branch March 24, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants