Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvc: optimize and clean up stages collection #3048

Merged
merged 1 commit into from
Jan 3, 2020
Merged

dvc: optimize and clean up stages collection #3048

merged 1 commit into from
Jan 3, 2020

Conversation

Suor
Copy link
Contributor

@Suor Suor commented Jan 3, 2020

  • no need to normalize paths
  • no need to manipulate with os.sep
  • use set instead of list

@Suor Suor requested a review from pared January 3, 2020 15:17
@Suor Suor requested a review from efiop January 3, 2020 16:16
efiop
efiop approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@efiop efiop merged commit 85c35f8 into iterative:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pared pared pared approved these changes

@efiop efiop efiop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suor @efiop @pared