Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point to troubleshooting guide on too many open files error #3017

Merged
merged 3 commits into from
Jan 16, 2020

Conversation

pared
Copy link
Contributor

@pared pared commented Dec 30, 2019

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@pared pared changed the title point to troubleshooting guide on too many open files error [WIP] point to troubleshooting guide on too many open files error Dec 30, 2019
@shcheklein
Copy link
Member

is it still WIP?

dvc/main.py Outdated
@@ -67,7 +67,9 @@ def main(argv=None):
)
elif isinstance(exc, OSError) and exc.errno == errno.EMFILE:
logger.exception(
"too many open files, please increase your `ulimit`"
"too many open files, please visit "
"https://dvc.org/doc/user-guide/troubleshooting to see how "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use format_link helper from utils.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't work yet, but when it will, it will probably have a separate section for that, right? If so, you need to use section link.

@pared
Copy link
Contributor Author

pared commented Jan 3, 2020

@shcheklein its still WIP, in order to prevent it from merging until iterative/dvc.org#875 gets deployed

dvc/main.py Outdated Show resolved Hide resolved
@pared pared changed the title [WIP] point to troubleshooting guide on too many open files error point to troubleshooting guide on too many open files error Jan 16, 2020
@efiop efiop merged commit d160f83 into iterative:master Jan 16, 2020
@efiop
Copy link
Contributor

efiop commented Jan 16, 2020

Thanks!

@pared pared deleted the errno_24_message branch March 24, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants