-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
point to troubleshooting guide on too many open files error #3017
Conversation
is it still WIP? |
dvc/main.py
Outdated
@@ -67,7 +67,9 @@ def main(argv=None): | |||
) | |||
elif isinstance(exc, OSError) and exc.errno == errno.EMFILE: | |||
logger.exception( | |||
"too many open files, please increase your `ulimit`" | |||
"too many open files, please visit " | |||
"https://dvc.org/doc/user-guide/troubleshooting to see how " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use format_link
helper from utils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link doesn't work yet, but when it will, it will probably have a separate section for that, right? If so, you need to use section link.
@shcheklein its still WIP, in order to prevent it from merging until iterative/dvc.org#875 gets deployed |
498f971
to
cbb4767
Compare
cbb4767
to
af7ec3c
Compare
af7ec3c
to
0fcbfd0
Compare
Thanks! |
β Have you followed the guidelines in the Contributing to DVC list?
π Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
β Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. π