Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdrive: add support for teamDriveId #3016

Merged
merged 1 commit into from
Jan 12, 2020
Merged

gdrive: add support for teamDriveId #3016

merged 1 commit into from
Jan 12, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 30, 2019

Fixes #3015

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop efiop force-pushed the 3015 branch 3 times, most recently from 64b17a3 to 34720ce Compare December 30, 2019 01:58
@efiop efiop requested a review from maxhora December 30, 2019 08:17
@efiop
Copy link
Contributor Author

efiop commented Jan 7, 2020

For the record, @Maxris is working on this feature now. πŸ™

@maxhora
Copy link
Contributor

maxhora commented Jan 10, 2020

Team Drive shared folder URL might look like following:

gdrive://0AIac4JZqHhKmUk9PDA/test

where 0AIac4JZqHhKmUk9PDA is shared drive root folder id obtained from web browser URL (it will look like https://drive.google.com/drive/folders/0AIac4JZqHhKmUk9PDA).

Description of changes in this PR:

@maxhora maxhora requested a review from shcheklein January 10, 2020 18:42
setup.py Show resolved Hide resolved
dvc/remote/gdrive.py Outdated Show resolved Hide resolved
dvc/remote/gdrive.py Outdated Show resolved Hide resolved
dvc/remote/gdrive.py Outdated Show resolved Hide resolved
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me, thanks!

Pending things to check:

  • tests
  • conda
  • docs update

@maxhora
Copy link
Contributor

maxhora commented Jan 11, 2020

docs update - iterative/dvc.org#914

@efiop efiop changed the title [WIP] gdrive: add support for teamDriveId gdrive: add support for teamDriveId Jan 12, 2020
@efiop
Copy link
Contributor Author

efiop commented Jan 12, 2020

Thank you so much @Maxris ! πŸ™

@efiop efiop merged commit 5b5810e into iterative:master Jan 12, 2020
@efiop efiop deleted the 3015 branch January 12, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support of team drives for GDrive remote
3 participants