Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commands/update: add --rev option #2993
commands/update: add --rev option #2993
Changes from 3 commits
b285780
95db0ea
beab3d5
9d68c8a
386b25e
32494bb
a9fa797
9a04fbd
f9e5cc9
1562ca4
8400eb3
4fe900f
5f61f0c
f3eb2cd
2abf41c
d2072b9
f56efc6
e6a56f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to do that. See
_make_rev
, where it will merge your args with def_repo anyways.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using
repo_dir
anddvc_repo
anymore, instead, we usetmp_dir
ordvc
.This is not crucial, but it would be nice if you could read the docstring from
tests/dir_helpers.py
.Sorry for the extra work, @ilgooz π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a suggestion, to save you some time:
Looks neat)