-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add snap tests #2956
add snap tests #2956
Conversation
Looks like they've had issues for a couple of days though: |
https://travis-ci.com/iterative/dvc/jobs/268243764#L2141
@efiop not sure how to debug this - the command works on my machine |
@casperdcl Let's start with full log first (add |
hm tried to re-run in case it was a connectivity issue. Also added
|
@casperdcl Sorry, just noticed your comment. Probably connectivity issues in the container? Maybe it needs some special perms to access the network? |
@casperdcl Was the issue resolved? |
nope, just mistakenly deleted the branch |
just rebased; will try to investigate. Do we have ssh debugging in travis @efiop? |
well running the snap's built-in version of git works ( |
also the fact that |
I'm pretty sure we don't. Or at least I'm not aware of it. Try modifying find_root https://github.com/iterative/dvc/blob/master/dvc/repo/__init__.py#L132 to print listdirs when he walks them. Looks like it doesn't see |
@casperdcl Looks good. Is this ready for merge? EDIT: got a confirmation in PMs. |
./scripts
channel: stable
pushes successfully (not justedge
)dvc
--version
version
doesn't work due to unknown CI (travis) issue; will test in add snap tests dvc-test#8 instead.get
# TODO
line in.travis.yml