-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS progress for push & pull #2809
Conversation
casperdcl
commented
Nov 17, 2019
•
edited
Loading
edited
- upload with progress
- download with progress
- add totals, filenames, disable, etc
- test
- fixes gs: support progress callback #1566
@efiop @xliiv this is the sort of thing I intended. The only reason I hadn't implement it before is I don't know how to test it (#1566 (comment)) |
8b2e5c9
to
908495d
Compare
- fixes iterative#1566
908495d
to
6fdba1d
Compare
@casperdcl Looks great! I've also had this implementation in mind. Btw, check your email 😉 |
I'm suspicious that the CI build passes - is GS actually tested on Travis? |
@casperdcl GS is not tested on regular PRs, only on master, as it uses some secrets for accessing our GS account. As I've noted in the comment under the issue, I'll try this out myself, because setting up GS from scratch will take longer than writing this PR 🙂 |
@casperdcl Just a heads up: gs chunking test failed. Just need to update it with the new default chunk size in mind |
@efiop think this is ready for merge |
@Suor Since you've left a review earlier, please take another look. Thank you 🙂 |
After progress discussion is resolved and if we are sure 100 MB chunks are not needed it will be good to merge. |
@casperdcl Thank you! 🙏 |