Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: output improvements #2546
add: output improvements #2546
Changes from all commits
9704810
f2db8d0
1909050
4aebdf7
c941c01
06b4495
6ac8935
0913ea6
f6fb05a
1c1763e
bf0a322
bdc8c70
17383ae
be7e766
ccf45ea
1bda5e2
9125ae7
628229e
7e47abd
78933a0
1fffaa8
f02951f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain what is going on here in general? The commit message doesn't have any explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was needed as previously only
logging.DEBUG
andlogging.WARNING
were handled bydvc.logger.LoggerHandler
. However this change ensures thatlogging.INFO
is also handled by our class. The custom class is required to ensure thatlogger.info()
interleaves properly withdvc.progress.Tqdm()
.I should've described this commit as "progress-aware
logger.info
"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one last question: Is this really a debug output? I also find that message useful in the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the thing is the tracked file name will be printed in the progress bar itself, while the dvc file names will all be printed at the end. This means this message should no longer be required. I left it in for 1. debugging and 2. not sure if the 12 other uses of
stage.dump()
actually need it to belogger.info
. This is the only real issue I have with this PR atm.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Feel fee to ask @efiop and/or resolve this conversation when you see fit. Thanks.