Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add rev param to api calls #2202

Merged
merged 3 commits into from
Jul 1, 2019
Merged

api: add rev param to api calls #2202

merged 3 commits into from
Jul 1, 2019

Conversation

Suor
Copy link
Contributor

@Suor Suor commented Jun 27, 2019

No description provided.

@Suor Suor requested a review from efiop June 27, 2019 15:50
shcheklein
shcheklein reviewed Jun 27, 2019
View reviewed changes
dvc/repo/__init__.py Outdated Show resolved Hide resolved
shcheklein
shcheklein reviewed Jun 27, 2019
View reviewed changes
dvc/api.py Show resolved Hide resolved
shcheklein
shcheklein requested changes Jun 27, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address a few comments.

@Suor
Copy link
Contributor Author

Suor commented Jun 28, 2019

rev for local repos is disabled with assert until #2201 is resolved. The rest is addressed.

@Suor Suor requested a review from shcheklein June 28, 2019 14:24
@efiop
Copy link
Contributor

efiop commented Jun 28, 2019

@Suor windows tests are failing

@efiop
Copy link
Contributor

efiop commented Jun 28, 2019

Might be a false-negative, restarted.

@Suor
Copy link
Contributor Author

Suor commented Jun 28, 2019

@efiop sometimes I randomly can't remove tmp repo dir, sometimes it's something unrelated.

@Suor Suor force-pushed the api-rev branch 3 times, most recently from c767e64 to 766b7d8 Compare July 1, 2019 14:24
efiop
efiop approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit cc9411d into iterative:master Jul 1, 2019
@Suor Suor deleted the api-rev branch July 1, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

@shcheklein shcheklein Awaiting requested review from shcheklein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suor @efiop @shcheklein