repro --pull implies --allow-missing #10434
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10412 (comment). When we introduced
--allow-missing
, we also updated the behavior of--pull
, but kept them as separate flags for a couple reasons (see discussion here):--pull
too muchSince then, every user I have encountered expects the behavior to be what
--pull --allow-missing
does. I don't see any valid case where someone using--pull
would not want--allow-missing
(we are basically already implying this by treating missing data as needing to be pulled).