add: raise DoesNotExistError only if the output path does not exist #10373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dvc add` command incorrectly raises a `DoesNotExistError` when a broken symlink exists in an output directory, and the target name is same as the directory's name. eg: If `data` is an output, and is the command is invoked as `dvc add data` (i.e. no virtual directory operations to perform). The expected behavior to raise a `FileNotFoundError`. `DoesNotExistError` should only be raised if the output itself does not exist. Related: iterative#3717
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10373 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 501 501
Lines 38837 38837
Branches 5616 5616
=======================================
Hits 35229 35229
Misses 2964 2964
Partials 644 644 ☔ View full report in Codecov by Sentry. |
BradyJ27
pushed a commit
to BradyJ27/dvc
that referenced
this pull request
Apr 22, 2024
…terative#10373) `dvc add` command incorrectly raises a `DoesNotExistError` when a broken symlink exists in an output directory, and the target name is same as the directory's name. eg: If `data` is an output, and is the command is invoked as `dvc add data` (i.e. no virtual directory operations to perform). The expected behavior to raise a `FileNotFoundError`. `DoesNotExistError` should only be raised if the output itself does not exist. Related: iterative#3717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dvc addcommand incorrectly raises aDoesNotExistErrorwhen a broken symlink exists in an output directory, and the target name is same as the directory's name.eg: If
datais an output, and the command is invoked asdvc add data(i.e. no virtual directory operations to perform).The expected behavior is to raise a
FileNotFoundError.DoesNotExistErrorshould only be raised if the output itself does not exist.Related: #3717