Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp save: Handle staged files like exp run #9058

Closed
Tracked by #8972
daavoo opened this issue Feb 20, 2023 · 0 comments · Fixed by #9165
Closed
Tracked by #8972

exp save: Handle staged files like exp run #9058

daavoo opened this issue Feb 20, 2023 · 0 comments · Fixed by #9165
Assignees
@daavoo
Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do

Comments

@daavoo
Copy link
Contributor

daavoo commented Feb 20, 2023 •
edited
Loading

Need to cover:

#6297
#8998
@daavoo daavoo mentioned this issue Feb 20, 2023
Closed
@daavoo daavoo added the A: experiments Related to dvc exp label Feb 20, 2023
@daavoo daavoo self-assigned this Feb 20, 2023
@daavoo daavoo added this to DVC Feb 20, 2023
@daavoo daavoo moved this from Backlog to In Progress in DVC Feb 20, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Feb 20, 2023
@dberenbaum dberenbaum added the p1-important Important, aka current backlog of things to do label Mar 13, 2023
daavoo added a commit that referenced this issue Mar 13, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
8286bf0 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 13, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
494c7a4 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
@daavoo daavoo mentioned this issue Mar 13, 2023
Merged
@daavoo daavoo linked a pull request Mar 13, 2023 that will close this issue
exp save: Reintroduce implementation based on executor/queue. #9165
Merged
@daavoo daavoo moved this from In Progress to Review In Progress in DVC Mar 13, 2023
daavoo added a commit that referenced this issue Mar 14, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
b397158 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 14, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
dabe361 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 21, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
29015e4 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 23, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
1f5f411 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 23, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
fc25e1b 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 23, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
aa987ca 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 23, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
3c36693 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 24, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
b7bbde5 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 24, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
c5b673d 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
daavoo added a commit that referenced this issue Mar 24, 2023
@daavoo
exp save: Reintroduce implementation based on executor/queue.
6b6dc01 
Closes #9058 .

Ensures behavior of `_stash_exp` in `exp run` is matched in `exp save` without duplicating logic.

The simpler implementation ended up being worse for maintenance when wanting to make `exp run` and `exp save` behavior in sync.
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in DVC Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daavoo daavoo

Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exp save: Reintroduce implementation based on executor/queue. iterative/dvc
2 participants
@dberenbaum @daavoo