Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

studio: queued experiments are not sending start/done events. #8951

Closed
daavoo opened this issue Feb 3, 2023 · 2 comments · Fixed by #8955 or #9161
Closed

studio: queued experiments are not sending start/done events. #8951

daavoo opened this issue Feb 3, 2023 · 2 comments · Fixed by #8955 or #9161
Assignees
@daavoo
Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. product: Studio Integration with Studio

Comments

@daavoo
Copy link
Contributor

daavoo commented Feb 3, 2023

Because they are being executed via https://github.com/iterative/dvc/blob/main/dvc/commands/experiments/exec_run.py#L11 instead of https://github.com/iterative/dvc/blob/main/dvc/repo/experiments/queue/workspace.py#L94 .

The usage of post_live_metrics should probably be moved to inside executor.reproduce
@daavoo daavoo added bug Did we break something? product: VSCode Integration with VSCode extension labels Feb 3, 2023
@daavoo daavoo self-assigned this Feb 3, 2023
@dberenbaum dberenbaum added the p0-critical Critical issue. Needs to be fixed ASAP. label Feb 3, 2023
@daavoo daavoo added this to DVC Feb 3, 2023
@daavoo daavoo moved this from Backlog to In Progress in DVC Feb 3, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Feb 3, 2023
@daavoo
Copy link
Contributor Author

daavoo commented Feb 3, 2023 •
edited
Loading

Also, the code for automatically infer STUDIO_REPO_URL doesn't work inside the queue because it relies on git parsing a config that is not available inside tmp dir where the exp is being executed:

https://github.com/iterative/dvc-studio-client/blob/main/src/dvc_studio_client/post_live_metrics.py#L22

daavoo added a commit that referenced this issue Feb 3, 2023
@daavoo
studio: Move post_live_metrics from queue/workspace to `executor/…
f8506fa 
…base`.

#8951 now works when manually setting `STUDIO_REPO_URL` as en env var.
@daavoo daavoo mentioned this issue Feb 3, 2023
Merged
@daavoo daavoo linked a pull request Feb 3, 2023 that will close this issue
studio: Move post_live_metrics from queue to executor #8955
Merged
@daavoo
Copy link
Contributor Author

daavoo commented Feb 6, 2023

Also, the code for automatically infer STUDIO_REPO_URL doesn't work inside the queue because it relies on git parsing a config that is not available inside tmp dir where the exp is being executed:

https://github.com/iterative/dvc-studio-client/blob/main/src/dvc_studio_client/post_live_metrics.py#L22

Will close the issue for now with #8955 .

We might consider .git/config just a subset of #5800 or rather a special case that could be considered separately

@github-project-automation github-project-automation bot moved this from In Progress to Done in DVC Feb 6, 2023
@daavoo daavoo mentioned this issue Mar 6, 2023
Closed
@daavoo daavoo reopened this Mar 13, 2023
@github-project-automation github-project-automation bot moved this from Done to Todo in DVC Mar 13, 2023
daavoo added a commit that referenced this issue Mar 13, 2023
@daavoo
exp: Include STUDIO_REPO_URL in run_env.
4322dc7 
Closes #8951.
@daavoo daavoo mentioned this issue Mar 13, 2023
Merged
daavoo added a commit that referenced this issue Mar 13, 2023
@daavoo
exp: Include STUDIO_REPO_URL in run_env.
9b834c6 
Closes #8951.
daavoo added a commit that referenced this issue Mar 14, 2023
@daavoo
exp: Include STUDIO_REPO_URL in run_env.
f5f92f2 
Closes #8951.
daavoo added a commit that referenced this issue Mar 14, 2023
@daavoo
exp: Include STUDIO_REPO_URL in run_env.
bd90373 
Closes #8951.
daavoo added a commit that referenced this issue Mar 14, 2023
@daavoo
exp: Include STUDIO_REPO_URL in run_env.
011c11f 
Closes #8951.
@github-project-automation github-project-automation bot moved this from Todo to Done in DVC Mar 14, 2023
daavoo added a commit that referenced this issue Mar 14, 2023
@daavoo
exp: Include STUDIO_REPO_URL in run_env.
e73cc9b 
Closes #8951.
@daavoo daavoo added product: Studio Integration with Studio and removed product: VSCode Integration with VSCode extension labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daavoo daavoo

Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. product: Studio Integration with Studio
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
2 participants
@dberenbaum @daavoo