Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp run: local config settings are not propagated into temp workspace #7254

Closed
Tracked by #8972
pmrowla opened this issue Jan 11, 2022 · 0 comments · Fixed by #9289
Closed
Tracked by #8972

exp run: local config settings are not propagated into temp workspace #7254

pmrowla opened this issue Jan 11, 2022 · 0 comments · Fixed by #9289
Assignees
@daavoo
Labels
A: experiments Related to dvc exp bug Did we break something? p1-important Important, aka current backlog of things to do

Comments

@pmrowla
Copy link
Contributor

pmrowla commented Jan 11, 2022

When generating the temp workspaces we do not respect the parent repo's config.local, so --local overrides for link types or state/index location will not be propagated and used during exp execution.
@pmrowla pmrowla added bug Did we break something? p2-medium Medium priority, should be done, but less important A: experiments Related to dvc exp labels Jan 11, 2022
@pmrowla pmrowla mentioned this issue Mar 23, 2022
Closed
@dberenbaum dberenbaum mentioned this issue Apr 11, 2022
Closed
@pmrowla pmrowla mentioned this issue Aug 8, 2022
Closed
@dberenbaum dberenbaum mentioned this issue Feb 6, 2023
Closed
@daavoo daavoo self-assigned this Mar 13, 2023
@dberenbaum dberenbaum added p1-important Important, aka current backlog of things to do and removed p2-medium Medium priority, should be done, but less important labels Mar 13, 2023
daavoo added a commit that referenced this issue Mar 30, 2023
@daavoo
exp run: Propagate .dvc/config.local in TempDirExecutor.
bd9dcd8 
Closes #7254
@daavoo daavoo mentioned this issue Mar 30, 2023
Merged
@daavoo daavoo linked a pull request Mar 30, 2023 that will close this issue
exp run: Propagate .dvc/config.local in TempDirExecutor. #9289
Merged
daavoo added a commit that referenced this issue Mar 30, 2023
@daavoo
exp run: Propagate .dvc/config.local in TempDirExecutor.
2233a0f 
Closes #7254
daavoo added a commit that referenced this issue Mar 31, 2023
@daavoo
exp run: Propagate .dvc/config.local in TempDirExecutor.
1d8b2e5 
Closes #7254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daavoo daavoo

Labels
A: experiments Related to dvc exp bug Did we break something? p1-important Important, aka current backlog of things to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exp run: Propagate .dvc/config.local in TempDirExecutor. iterative/dvc
3 participants
@pmrowla @dberenbaum @daavoo