Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc: implement cleanup/removal of completed processes #7063

Closed
2 tasks done
pmrowla opened this issue Nov 29, 2021 · 0 comments · Fixed by #7067
Closed
2 tasks done

proc: implement cleanup/removal of completed processes #7063

pmrowla opened this issue Nov 29, 2021 · 0 comments · Fixed by #7067
Assignees
@karajan1001
Labels
A: executors Related to the executors feature

Comments

@pmrowla
Copy link
Contributor

pmrowla commented Nov 29, 2021 •
edited
Loading

ProcessManager does not automatically remove completed processes from the managed directory (so that exit status and output logs can be retrieved completion). The manager API will still need to support cleaning up these process directories once they are no longer needed.

  • remove - note that remove() should support forcefully terminating existing running processes
  • cleanup

Follow up to #7048
Prerequisite for #6267
@pmrowla pmrowla added the A: executors Related to the executors feature label Nov 29, 2021
@pmrowla pmrowla added this to DVC Nov 29, 2021
@pmrowla pmrowla moved this to Backlog in DVC Nov 29, 2021
@karajan1001 karajan1001 moved this from Backlog to In Progress in DVC Nov 29, 2021
@karajan1001 karajan1001 moved this from In Progress to Todo in DVC Nov 29, 2021
@karajan1001 karajan1001 mentioned this issue Nov 30, 2021
Merged
2 tasks
@karajan1001 karajan1001 moved this from Todo to In Progress in DVC Nov 30, 2021
karajan1001 added a commit to karajan1001/dvc that referenced this issue Dec 3, 2021
@karajan1001
proc: implement cleanup/removal (iterative#7063)
023688a 
fix: iterative#7063
Add `cleanup` and `removal` function to ProcessManager
pmrowla pushed a commit that referenced this issue Dec 6, 2021
@karajan1001 @pmrowla
proc: implement cleanup/removal (#7063)
9cf1f45 
fix: #7063
Add `cleanup` and `removal` function to ProcessManager
Repository owner moved this from In Progress to Done in DVC Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karajan1001 karajan1001

Labels
A: executors Related to the executors feature
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proc: implement cleanup/removal (#7063) karajan1001/dvc
2 participants
@pmrowla @karajan1001