Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config --local: disable/remove help text for irrelevant commands #6940

Closed
dberenbaum opened this issue Nov 8, 2021 · 1 comment · Fixed by #6950
Closed

config --local: disable/remove help text for irrelevant commands #6940

dberenbaum opened this issue Nov 8, 2021 · 1 comment · Fixed by #6950
Labels
A: cli Related to the CLI A: executors Related to the executors feature

Comments

@dberenbaum
Copy link
Collaborator

dberenbaum commented Nov 8, 2021 •
edited
Loading

Extracted from #6855 (comment):

machine status shows the machine running status which is decoupled with the original machine config. So no --global/system/project/local for it. But for now, it shows is in the help UI, we need to remove them. Btw, this UI issue also exists in some other machine commands, create, ssh etc. We can create an issue for it.
@dberenbaum dberenbaum added the A: cli Related to the CLI label Nov 8, 2021
@karajan1001 karajan1001 added the A: executors Related to the executors feature label Nov 9, 2021
@karajan1001
Copy link
Contributor

karajan1001 commented Nov 10, 2021 •
edited
Loading

In #6440

Only add, remove, list, and modify needs --local/project/system/global flag.

Remove them in create, destroy, status, ssh.

For rename, the current logic is that. It renames all levels if no level argument is provided. If we provide a special level, it will only affect configs above that level. (ie, only project and local if with a --project flag). I guess we can keep it for now.

@karajan1001 karajan1001 mentioned this issue Nov 10, 2021
Merged
2 tasks
karajan1001 added a commit to karajan1001/dvc that referenced this issue Nov 17, 2021
@karajan1001
machine:remove help text for irrelevant commands (iterative#6940)
10a2e4d 
fix: iterative#6940

`--global/system/project/local` help message are in some irrelevant
command `status`, `ssh`, `create`, `destroy`. These commands are more
related to running instances rather than `machine config`, level
options didn't work for them.

1. Remove `--global/system/project/local` options in `status`, `ssh`,
   `create`, `destroy`.
2. Add a test for it.
3. Correct a typo error.
karajan1001 added a commit that referenced this issue Nov 17, 2021
@karajan1001
machine:remove help text for irrelevant commands (#6940)
eea67a6 
fix: #6940

`--global/system/project/local` help message are in some irrelevant
command `status`, `ssh`, `create`, `destroy`. These commands are more
related to running instances rather than `machine config`, level
options didn't work for them.

1. Remove `--global/system/project/local` options in `status`, `ssh`,
   `create`, `destroy`.
2. Add a test for it.
3. Correct a typo error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: cli Related to the CLI A: executors Related to the executors feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

machine:remove help text for irrelevant commands karajan1001/dvc
2 participants
@dberenbaum @karajan1001