-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp init: when to fail for non-existent params #6865
Comments
Should it fail, at all? Maybe I'm a little out of context for intended |
For params, we don't have a choice but to fail unless we implement #6605, because we need to specify all the individual parameter names in Without other changes in functionality, we can either fail only for a missing parameters file, or fail for any missing dependency. At the very least, in interactive mode, we shouldn't prompt them several more times and then fail because the parameters file is missing. For the primary use case of making it easy for new users, it might be useful to guide them towards first creating the necessary dependencies and not ending up with a broken stage. |
It makes sense to fail right away for the params as we need them to exist for us to create a stage. I am not so sure about other dependencies, we tried to decouple the runtime behaviour with the metadata tracking behaviour on I'll add a check for the params. |
It'll give a error message to the user and reprompt them. This mechanism can be extended to other prompts, and we can show a warning message and/or reprompt them based on validations. Closes iterative#6865. Part of iterative#6446.
From #6750 (comment):
exp init
fails ifparams.yaml
does not exist since the params are parsed to generate the stage. Related: #6605.In interactive mode, it would be nice to fail as soon as possible (right after path to params is provided).
For other dependencies, I wonder if
dvc exp init
should also validate that the paths exist. This could help guide users. It could be annoying if users want to dodvc exp init
before creating projects files, but this seems unlikely to me outside of toy scenarios.The text was updated successfully, but these errors were encountered: