Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plots --open: not working on macOS #6092

Closed
skshetry opened this issue Jun 1, 2021 · 0 comments · Fixed by #6845
Closed

plots --open: not working on macOS #6092

skshetry opened this issue Jun 1, 2021 · 0 comments · Fixed by #6845
Labels
A: plots Related to the plots bug Did we break something? P: macOS Related to the Platform: macOS p1-important Important, aka current backlog of things to do

Comments

@skshetry
Copy link
Member

skshetry commented Jun 1, 2021

We use relpath to open files in the browser.

dvc/dvc/command/plots.py

Line 60 in 59cfc2c

opened = webbrowser.open(rel)

This is mostly done to support wsl, and the fact that all other Platform seem to work, if it's relative or absolute.

The reason why it does not work is because web browser.open messes up. 🤦🏼
https://github.com/python/cpython/blob/39dd141a4ba68bbb38fd00a65cdcff711acdafb5/Lib/webbrowser.py#L638-L639
@skshetry skshetry added bug Did we break something? p1-important Important, aka current backlog of things to do P: macOS Related to the Platform: macOS labels Jun 1, 2021
@daavoo daavoo added the A: plots Related to the plots label Oct 20, 2021
@daavoo daavoo mentioned this issue Oct 20, 2021
Merged
daavoo added a commit that referenced this issue Oct 27, 2021
@daavoo
plots: Use URI for --open.
ed59d7e 
We were previously using relpath in *all* cases, mainly to support WSL but relpath doesn't work
on macOS.

Added a check for using relpath *only* for WSL.

Fixes #6092
pared pushed a commit that referenced this issue Oct 29, 2021
@daavoo @pared
plots: Use URI for --open.
4dd5441 
We were previously using relpath in *all* cases, mainly to support WSL but relpath doesn't work
on macOS.

Added a check for using relpath *only* for WSL.

Fixes #6092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: plots Related to the plots bug Did we break something? P: macOS Related to the Platform: macOS p1-important Important, aka current backlog of things to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plots: Use URI for --open. iterative/dvc
2 participants
@daavoo @skshetry