Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get[-url]/import-url: jobs option? #5267

Closed
jorgeorpinel opened this issue Jan 13, 2021 · 4 comments · Fixed by #5362
Closed

get[-url]/import-url: jobs option? #5267

jorgeorpinel opened this issue Jan 13, 2021 · 4 comments · Fixed by #5362
Assignees
@isidentical
Labels
enhancement Enhances DVC

Comments

@jorgeorpinel
Copy link
Contributor

import has --jobs (used by most commands that download data from DVC remotes) but get is missing it.

And what about import-url and get-url? They use the same remote interfaces after all.
@jorgeorpinel jorgeorpinel added the enhancement Enhances DVC label Jan 13, 2021
@isidentical
Copy link
Contributor

I avoided adding --jobs until we decided on whether to use both add/import-url or one of them, but we will definitely need it for #5198!

@isidentical
Copy link
Contributor

By the way, repo.imp_url() already takes a jobs= parameter so only thing missing is a CLI arg

@isidentical isidentical self-assigned this Jan 29, 2021
@isidentical isidentical mentioned this issue Jan 29, 2021
Merged
2 tasks
@jorgeorpinel
Copy link
Contributor Author

Thanks! #5362 didn't implement import-url --jobs though. Is that because we decided not to? Or should we reopen this for that last detail.

@isidentical
Copy link
Contributor

It is already implemented in my straight-to-remote PR

jorgeorpinel added a commit to iterative/dvc.org that referenced this issue Feb 2, 2021
@jorgeorpinel
cmd: add import-url --jobs
619e36a 
per iterative/dvc#5267 (comment)
@jorgeorpinel jorgeorpinel mentioned this issue Feb 2, 2021
Merged
shcheklein pushed a commit to iterative/dvc.org that referenced this issue Feb 5, 2021
@isidentical @jorgeorpinel
get, get-url: add --jobs option (#2122)
a1b50de 
* get, get-url: add --jobs option

* cmd: consistent --jobs desc.

* cmd: add import-url --jobs
per iterative/dvc#5267 (comment)

* cmd: roll back sync command changes
per #2122 (review)

* -j config

Co-authored-by: Jorge Orpinel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isidentical isidentical

Labels
enhancement Enhances DVC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

get, get-url: add --jobs option isidentical/dvc
2 participants
@jorgeorpinel @isidentical