Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous message for non-plot target on plots modify #4741

Closed
pared opened this issue Oct 19, 2020 · 2 comments
Closed

Ambiguous message for non-plot target on plots modify #4741

pared opened this issue Oct 19, 2020 · 2 comments
Labels
p3-nice-to-have It should be done this or next sprint ui user interface / interaction

Comments

@pared
Copy link
Contributor

pared commented Oct 19, 2020

DVC version: 1.8.4

After #4590 we support plotting for any "plot-able" file.

Support for plotting does not mean support for modifying the plot - since we don't have a place to write the information to.

plots modify-ing non plot file will result:
ERROR: Unable to find DVC-file with output '{filename}'
This message should probably be more clear in this context. Something like
ERROR: '{filename}' is not marked as plot in any DVC-file, and it cannot be modified.

Related to: iterative/dvc.org#1809
@pared pared added p3-nice-to-have It should be done this or next sprint ui user interface / interaction labels Oct 19, 2020
@efiop
Copy link
Contributor

efiop commented Oct 19, 2020

Oops, my fault for marking everything in plots as being able to work without repo. Sending a quick fix.

@efiop efiop self-assigned this Oct 19, 2020
@efiop
Copy link
Contributor

efiop commented Oct 19, 2020

Ah, ok, I misread the issue. This is not about working in non-dvc repo, but just dvc plots modify in general. Ok, nevermind.

@efiop efiop removed their assignment Oct 19, 2020
@efiop efiop mentioned this issue Oct 19, 2020
Merged
2 tasks
@jorgeorpinel jorgeorpinel mentioned this issue Oct 20, 2020
Merged
daavoo added a commit that referenced this issue Apr 28, 2023
@daavoo
reproduce: Update pull flag to also pull run cache and mising deps.
3309726 
Closes #4741
daavoo added a commit that referenced this issue May 2, 2023
@daavoo
reproduce: Update pull flag to also pull run cache and mising deps.
907cf03 
Closes #4741
@efiop efiop closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3-nice-to-have It should be done this or next sprint ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@efiop @pared