Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash/Zsh autocompletion scripts of command DVC remote rename #3847

Closed
karajan1001 opened this issue May 22, 2020 · 4 comments · Fixed by #3868
Closed

Bash/Zsh autocompletion scripts of command DVC remote rename #3847

karajan1001 opened this issue May 22, 2020 · 4 comments · Fixed by #3868
Labels
completion bash and zsh completion scripts p1-important Important, aka current backlog of things to do

Comments

@karajan1001
Copy link
Contributor

According to @shcheklein in iterative/dvc.org#1318 autocompletion scripts are forgotten in the previous PR #3794 .
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label May 22, 2020
@efiop efiop added completion bash and zsh completion scripts p1-important Important, aka current backlog of things to do labels May 22, 2020
@triage-new-issues triage-new-issues bot removed triage Needs to be triaged labels May 22, 2020
@karajan1001
Copy link
Contributor Author

karajan1001 commented May 23, 2020 •
edited
Loading

Hi, @efiop
May I ask a question? What does Tag completion means. Literally, it means this issues had been solved, but I found neither a PR nor a linked issue?

I was just going to look into it.

@skshetry
Copy link
Member

@karajan1001, it means this issue is about fixing auto-completion scripts.

You can take a look into it, if you can. 🙂

@karajan1001 karajan1001 mentioned this issue May 23, 2020
Merged
karajan1001 added a commit to karajan1001/dvc that referenced this issue May 24, 2020
@karajan1001
Auto-completion of the dvc remote rename command
1509ecf 
fix iterative#3847
@karajan1001 karajan1001 mentioned this issue May 24, 2020
Merged
3 tasks
@karajan1001
Copy link
Contributor Author

@skshetry Thank you. Haha, the name completion confused me.

I had updated the two scripts and tested them on my own computer. But there is another question that is there any method to create unit-tests for them?

efiop pushed a commit that referenced this issue May 24, 2020
@karajan1001
Auto-completion of the dvc remote rename command (#3868)
c5920b0 
fix #3847
@efiop
Copy link
Contributor

efiop commented May 24, 2020

@karajan1001 No unit tests required for those 🙂 Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completion bash and zsh completion scripts p1-important Important, aka current backlog of things to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto-completion of the dvc remote rename command karajan1001/dvc
3 participants
@efiop @karajan1001 @skshetry