Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: fails for multi-file patches #3751

Closed
casperdcl opened this issue May 6, 2020 · 2 comments · Fixed by #3912
Closed

pre-commit: fails for multi-file patches #3751

casperdcl opened this issue May 6, 2020 · 2 comments · Fixed by #3912
Assignees
@efiop
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research

Comments

@casperdcl
Copy link
Contributor

casperdcl commented May 6, 2020 •
edited
Loading

  • pre-commit fails when there are more files to check than hyperthreads on the machine
  • error message about .dvc/tmp/lock is misleading and uphelpful

Steps to reproduce:

dvc (master)$ pre-commit run --all-files
black....................................................................Passed
flake8...................................................................Passed
beautysh.................................................................Passed
DVC pre-commit...........................................................Failed
- hook id: dvc-pre-commit
- duration: 6.17s
- exit code: 1

ERROR: failed to obtain data status - cannot perform the command because another DVC process seems to be running on this project. If that is not the case, manually remove `.dvc/tmp/lock` and try again.

Having any troubles? Hit us up at https://dvc.org/support, we are always happy to help!

require_serial: true in the pre-commit config doesn't seem to help
@casperdcl casperdcl added bug Did we break something? research labels May 6, 2020
@casperdcl casperdcl changed the title pre-commit: fails for multiple file commits pre-commit: fails for multi-file patches May 6, 2020
@casperdcl casperdcl mentioned this issue May 6, 2020
Merged
7 tasks
@weekly-digest weekly-digest bot mentioned this issue May 10, 2020
Closed
@efiop
Copy link
Contributor

efiop commented May 20, 2020

Another user experiencing this https://opendatascience.slack.com/archives/CGGLZJ119/p1589988401138600 . Escalating the priority.

@efiop efiop added the p0-critical Critical issue. Needs to be fixed ASAP. label May 20, 2020
@casperdcl
Copy link
Contributor Author

updated description a bit.

@efiop efiop added p1-important Important, aka current backlog of things to do and removed p0-critical Critical issue. Needs to be fixed ASAP. labels May 25, 2020
@efiop efiop self-assigned this May 29, 2020
@efiop efiop mentioned this issue May 29, 2020
Merged
3 tasks
efiop added a commit to efiop/dvc that referenced this issue May 29, 2020
@efiop
pre-commit: don't run dvc in parallel
3d82e64 
By default pre-commit will try to run hooks in parallel, which results
in some dvc instances failing to acquire repo locks.

Fixes iterative#3751
efiop added a commit that referenced this issue May 29, 2020
@efiop
pre-commit: don't run dvc in parallel (#3912)
f504245 
* pre-commit: use local hooks

* pre-commit: don't run dvc in parallel

By default pre-commit will try to run hooks in parallel, which results
in some dvc instances failing to acquire repo locks.

Fixes #3751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
bug Did we break something? p1-important Important, aka current backlog of things to do research
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pre-commit: don't run dvc in parallel efiop/dvc
2 participants
@efiop @casperdcl