Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run: params are not checked before running the command #3707

Closed
skshetry opened this issue Apr 30, 2020 · 0 comments · Fixed by #3709
Closed

run: params are not checked before running the command #3707

skshetry opened this issue Apr 30, 2020 · 0 comments · Fixed by #3709
Assignees
@efiop
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do ui user interface / interaction

Comments

@skshetry
Copy link
Member 

$ dvc run -n train1 -d users.csv -p tr_conf.yaml:epochs1,log_file,dropout -M e1/summary.json -m e1/logs.csv -o e1/logs python train.py
.... training is happening
.... 27 hours latter:
60000/60000 [==============================] - 6s 94us/sample - loss: 0.0588 - accuracy: 0.9806 - val_loss: 0.0707 - val_accuracy: 0.9821
ERROR: failed to run command - Parameters 'epochs1' are missing from 'tr_conf.yaml'.
@skshetry skshetry added the ui user interface / interaction label Apr 30, 2020
@efiop efiop added bug Did we break something? p1-important Important, aka current backlog of things to do labels Apr 30, 2020
@efiop efiop self-assigned this Apr 30, 2020
@efiop efiop mentioned this issue Apr 30, 2020
Merged
3 tasks
efiop added a commit to efiop/dvc that referenced this issue Apr 30, 2020
@efiop
run: try to save deps before running the command
a7117a7 
Unlike old `_check_missing_deps`, this also verifies that we are able to
save more complex dependencies such as parameters, where we not only
care about the config file, but also about the parameters in it.

Fixes iterative#3707
efiop added a commit that referenced this issue Apr 30, 2020
@efiop
run: try to save deps before running the command (#3709)
71d156a 
Unlike old `_check_missing_deps`, this also verifies that we are able to
save more complex dependencies such as parameters, where we not only
care about the config file, but also about the parameters in it.

Fixes #3707
@weekly-digest weekly-digest bot mentioned this issue May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
bug Did we break something? p1-important Important, aka current backlog of things to do ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run: try to save deps before running the command efiop/dvc
2 participants
@efiop @skshetry