Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: rename Windows package installation name #3687

Closed
fabiosantoscode opened this issue Apr 27, 2020 · 6 comments
Closed

install: rename Windows package installation name #3687

fabiosantoscode opened this issue Apr 27, 2020 · 6 comments
Labels
awaiting response we are waiting for your reply, please respond! :) enhancement Enhances DVC

Comments

@fabiosantoscode
Copy link
Contributor

fabiosantoscode commented Apr 27, 2020 •
edited by jorgeorpinel
Loading

UPDATE: Jump to #3687 (comment)

I've used the windows .exe installer to install DVC, but now I can't find it in the "add or remove programs" screen in the Control Panel.

However, this page reads:

You may use Windows Uninstaller to remove the program.

I think this line should either contain a more accurate description of how to uninstall, or not be present.
@jorgeorpinel jorgeorpinel transferred this issue from iterative/dvc.org Apr 27, 2020
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Apr 27, 2020
@jorgeorpinel jorgeorpinel changed the title Indication on how to uninstall DVC on windows is inaccurate. install: can't uninstall binary on windows Apr 27, 2020
@jorgeorpinel
Copy link
Contributor

I'll remove the note from docs for now... In iterative/dvc.org#1195

@jorgeorpinel jorgeorpinel changed the title install: can't uninstall binary on windows install: can't uninstall Windows binary Apr 27, 2020
@efiop
Copy link
Contributor

efiop commented Apr 27, 2020

@fabiosantoscode IIRC, it is called Data Version Control there. Might want to rename it to DVC, for sure.

@efiop
Copy link
Contributor

efiop commented Apr 27, 2020

For the record, here is where it is defined https://github.com/iterative/dvc/blob/master/scripts/innosetup/setup.iss#L1

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Apr 27, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Apr 27, 2020
@jorgeorpinel jorgeorpinel changed the title install: can't uninstall Windows binary install: rename Windows package installation name Apr 28, 2020
@jorgeorpinel
Copy link
Contributor

OMG you're right 🤦‍♂️

image

Maybe rename it "DVC (Data Version Control)" ?

Updated issue desc.

@jorgeorpinel jorgeorpinel added the enhancement Enhances DVC label Apr 28, 2020
@efiop efiop closed this as completed in a7b7767 Apr 28, 2020
@efiop
Copy link
Contributor

efiop commented Apr 28, 2020

@jorgeorpinel Adjusted it like that for now. Thanks!

@jorgeorpinel
Copy link
Contributor

Thank you!

@weekly-digest weekly-digest bot mentioned this issue May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting response we are waiting for your reply, please respond! :) enhancement Enhances DVC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jorgeorpinel @fabiosantoscode @efiop