Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: show: --outs: DAG has improper edges #3588

Closed
liamtoran opened this issue Apr 3, 2020 · 0 comments
Closed

pipeline: show: --outs: DAG has improper edges #3588

liamtoran opened this issue Apr 3, 2020 · 0 comments
Labels
bug Did we break something? p2-medium Medium priority, should be done, but less important

Comments

@liamtoran
Copy link

liamtoran commented Apr 3, 2020 •
edited
Loading

Issue :
In the DAG for --outs , all outputs from a connected stage are linked to the output of the stage.

Steps to recreations :

dvc run -o alice -o bob -f step1.dvc ' touch alice | touch bob ' 
dvc run -d alice -o carol -f step2.dvc ' touch carol '
dvc pipeline show --ascii --outs step2.dvc

Screen Shot 2020-04-03 at 8 40 59 AM

There shouldn't be an edge going from bob to carol.

Probably related to this line ?

dvc/dvc/command/pipeline.py

Line 63 in a338fad

edges.append((str(from_out), str(to_out)))

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Apr 3, 2020
@efiop efiop added bug Did we break something? p2-medium Medium priority, should be done, but less important labels Apr 6, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Apr 6, 2020
karajan1001 added a commit to karajan1001/dvc that referenced this issue May 9, 2020
@karajan1001
fix iterative#3588
1c348da 
remove improper edges from output DAG.
@efiop efiop closed this as completed in 76b31ac May 9, 2020
@weekly-digest weekly-digest bot mentioned this issue May 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Did we break something? p2-medium Medium priority, should be done, but less important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@efiop @liamtoran