-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics diff with missing old value #3469
Comments
Partial fix for iterative#3469
Not sure why it should be like that. Table as well as |
I'd prefer to have an empty output in this case. No need in a special message. It is a usual approach for many commands including |
@dmpetrov But we've been talking about dvc commands being too silent, hence why we've introduced such summary messages everywhere. |
Don't have a strong opinion on this ( It's better to be consistent with other DVC "diff" commands though. |
@dmpetrov noticed that it makes it not possible to use |
Also probably time to use |
@efiop do we have the same problem (not sure though why --json could not be used for example in the same bash check) for other commands? again, just to make sure that we are consistent more or less |
All the "information" commands need output nothing if there no information. This way you can easily use them from scripts like
Otherwise, we are pushing people to parse the outputs - For "action" commands (not "information") like |
Would you consider |
I really think that the reason behind |
Yeah. That's the thought one :) It is kind of informational but does some advanced stuff. It might be better for
Hm.. I thought it is often used command. I use it a lot. You are right in the sense that it is optimized a bit for machines. This should be the case for many informational commands. |
don't see any strong reason for this. It's not white and black. And I think people who write scripts are totally fine with a quite option, json or whatever. They have way higher tolerance in my mind than regular data scientists who can be surprised (?) |
Makes it easier to use in shell scripts. E.g. `-z $(dvc metrics diff)`, which has the same semantics as `git diff`. Also syncs up with the behaviour of `dvc diff`. Fixes iterative#3469
Makes it easier to use in shell scripts. E.g. `-z $(dvc metrics diff)`, which has the same semantics as `git diff`. Also syncs up with the behaviour of `dvc diff`. Fixes #3469
If metrics file(s) has only no old version (it was just created):
Expected the same output with no difference:
In JSON - the same output with no old values.
Also, the error message is misleading:
ERROR: unexpected error - 'HEAD^'
. It should be something likeERROR: the old version of the metric file is not found
Another problem is writing status to STDOUT (it should be in STDIN).
Summary:
The text was updated successfully, but these errors were encountered: