Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address dvc list review from Jorge #3381

Closed
efiop opened this issue Feb 22, 2020 · 10 comments · Fixed by #3462
Closed

address dvc list review from Jorge #3381

efiop opened this issue Feb 22, 2020 · 10 comments · Fixed by #3462
Assignees
Labels
p1-important Important, aka current backlog of things to do refactoring Factoring and re-factoring

Comments

@efiop
Copy link
Contributor

efiop commented Feb 22, 2020

Click #3246 (review)

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Feb 22, 2020
@efiop efiop added the refactoring Factoring and re-factoring label Feb 22, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Feb 22, 2020
@jorgeorpinel
Copy link
Contributor

Awesome! Please also check the latest state of the changes in iterative/dvc.org/pull/967 so both sides are in sync when this is addressed 🙂

@efiop efiop added the p1-important Important, aka current backlog of things to do label Feb 22, 2020
@gurobokum gurobokum self-assigned this Feb 25, 2020
@jorgeorpinel
Copy link
Contributor

Also, should the file name be list.py? its ls.py now.

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel
Copy link
Contributor

Another question here: is there an easy way to tell which files in the list are tracked by DVC and which ones by Git? This is kind of important for finding paths that can be sent to dvc import/get.

@gurobokum
Copy link
Contributor

@jorgeorpinel At this moment only coloring is supported as a way of the differentiating types of the files.
You may read more in the comment

@shcheklein
Copy link
Member

@JIoJIaJIu I think that link is just somewhat relevant. We have two things to colorize in a different way:

  1. DVC tracked files - e.g. we need to use a different color for a directory we did dvc add data\ with. Or the same for dvc add data\data.xml. And we should have a flag (--outs?) to filter DVC "outputs" only.
  2. DVC-files - we can use a color scheme for links, for example (since they serve to some extent as a link)
  3. Git-traked .dvcignored files.

That link it probably relevant to 3 only, but most likely @jorgeorpinel was asking about 1.

@gurobokum
Copy link
Contributor

That link it probably relevant to 3 only

In the comment I provided info about 1 and 2 scenarios, but the main issue relates to 3, right
Let me summarize it here then

We color output as out=color

LS_COLORS="out=01;37" dvc list ...

will color outs only

@jorgeorpinel

This comment has been minimized.

@shcheklein

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-important Important, aka current backlog of things to do refactoring Factoring and re-factoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants