Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyFile2 not supported in Windows 7 #3259

Closed
ghost opened this issue Jan 30, 2020 · 2 comments
Closed

CopyFile2 not supported in Windows 7 #3259

ghost opened this issue Jan 30, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 30, 2020

A user reported on discord that dvc add was throwing the following error:

ERROR: unexpected error - function 'CopyFile2' not found

Here's the output of dvc version:

DVC version: 0.82.6
Python version: 3.6.3
Platform: Windows-7-6.1.7601-SP1
Binary: False
Package: pip
Cache: reflink - not supported, hardlink - supported, symlink - not supported

We are using CopyFile2 on Windows to increase the performance of copy (see speedcopy), but that system call was introduced in Windows 8.

The solution was to pip uninstall speedcopy and let DVC fallback to Python's copy implementation.

What should we do?

  • Catch AttributeError: function 'CopyFile2' not found and output an actionable error message to fix it.
  • State in README / docs that we don't support < Windows 8?
  • Nothing?
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jan 30, 2020
@ghost ghost removed the triage Needs to be triaged label Jan 30, 2020
@shcheklein
Copy link
Member

Looks like Windows 7 EOL is already here? Considering that the whole Windows users share for DVC is about 2% or something not sure we should spend too much time on it?

We definitely should introduce some user-friendly message though and change docs is needed.

@ghost
Copy link
Author

ghost commented Jan 30, 2020

@ghost ghost closed this as completed Jan 30, 2020
charlesbaynham added a commit to charlesbaynham/dvc that referenced this issue Apr 2, 2020
efiop pushed a commit that referenced this issue Apr 2, 2020
* system: Only import speedcopy for Windows > 7

Fixes #3259

* Allow for Win 8

Co-authored-by: Charles Baynham <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant