Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: get_url() returns path to .dir for directory #3182

Closed
skshetry opened this issue Jan 17, 2020 · 6 comments
Closed

api: get_url() returns path to .dir for directory #3182

skshetry opened this issue Jan 17, 2020 · 6 comments
Labels
feature request Requesting a new feature p2-medium Medium priority, should be done, but less important

Comments

@skshetry
Copy link
Member

skshetry commented Jan 17, 2020 •
edited
Loading

Currently, get_url() returns path to .dir files. I'd propose to have some way to parse get_url() and return list or dicts (or, iterator) of files inside the directory (get_url(recurse=True)?).

dvc get . dir/ --show-url works the same way.
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jan 17, 2020
This was referenced Jan 17, 2020
Merged
Closed
@Suor
Copy link
Contributor

Suor commented Jan 18, 2020 •
edited
Loading

I am not a big fan of complicating .get_url(), this was always intended for files not dirs. Maybe we should not support .get_url() for dirs at all? What's the use case anyway?

@efiop
Copy link
Contributor

efiop commented Jan 19, 2020 •
edited
Loading

Note: as we've discussed in #2994 , get_url might not even be able to access the cache url that it shows, so we won't always be able to parse .dir 🙁 User of get_url might download .dir himself and parse it as a workaround.

I would wait for requests from users before going forward with this.

@efiop efiop added feature request Requesting a new feature p3-nice-to-have It should be done this or next sprint labels Jan 19, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Jan 19, 2020
jorgeorpinel added a commit to iterative/dvc.org that referenced this issue Jan 22, 2020
@jorgeorpinel
cache: improve note about .dir files and add in appropriate docs
0324fa2 
rel: iterative/dvc/issues/3182
jorgeorpinel added a commit to iterative/dvc.org that referenced this issue Jan 22, 2020
@jorgeorpinel
cmd ref: add a couple more notes about .dir files
7d1b469 
ref: iterative/dvc/issues/3182
@jorgeorpinel

This comment has been minimized.

Sign in to view
jorgeorpinel added a commit to iterative/dvc.org that referenced this issue Jan 23, 2020
@jorgeorpinel
api ref: add note about .dir cache files in get_url
24f2d67 
ref: iterative/dvc/issues/3182
@efiop efiop mentioned this issue Feb 28, 2020
Closed
@efiop efiop added p2-medium Medium priority, should be done, but less important and removed p3-nice-to-have It should be done this or next sprint labels May 25, 2020
@efiop efiop mentioned this issue Aug 24, 2020
Closed
2 tasks
@efiop efiop mentioned this issue Sep 21, 2020
Closed
@skshetry skshetry mentioned this issue Dec 19, 2020
Closed
@islamashraf98
Copy link

I think it would be a great option to be added, I have tons of images in a directory, so it would be more practical to get them once using get_url()

@dberenbaum
Copy link
Collaborator

@islamashraf98 You may want to take a look at #6850.

@dberenbaum dberenbaum mentioned this issue May 20, 2022
Closed
@skshetry
Copy link
Member Author

Closing as stale.

@skshetry skshetry closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requesting a new feature p2-medium Medium priority, should be done, but less important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: refactor to use metadata and RepoTree skshetry/dvc
6 participants
@Suor @jorgeorpinel @dberenbaum @efiop @skshetry @islamashraf98