Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvc add absolute_path #2955

Closed
casperdcl opened this issue Dec 14, 2019 · 0 comments · Fixed by #2975
Closed

dvc add absolute_path #2955

casperdcl opened this issue Dec 14, 2019 · 0 comments · Fixed by #2975
Assignees
@casperdcl
Labels
bug Did we break something? enhancement Enhances DVC good first issue p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@casperdcl
Copy link
Contributor

~/repo$ dvc add $HOME/repo/file should realise that the file is not "external" and add it as a relative path rather than absolute.
@casperdcl casperdcl added bug Did we break something? enhancement Enhances DVC ui user interface / interaction labels Dec 14, 2019
@casperdcl casperdcl self-assigned this Dec 14, 2019
@efiop efiop added p2-medium Medium priority, should be done, but less important good first issue help wanted labels Dec 14, 2019
@casperdcl casperdcl mentioned this issue Dec 18, 2019
Merged
5 tasks
@dmpetrov dmpetrov mentioned this issue Jan 19, 2020
Closed
casperdcl added a commit to casperdcl/dvc that referenced this issue Feb 6, 2020
@casperdcl
add: auto convert absolute_path => relative
ed45313 
- fixes iterative#2955
efiop pushed a commit that referenced this issue Feb 10, 2020
@casperdcl
add: auto convert absolute_path => relative (#2975)
3d5b8ec 
* add: auto convert absolute_path => relative

- fixes #2955

* use path_isin

* catch-all absolute paths in repo

* unneeded leftover

* revert realtive imports for later

* output: move abs2relpath from Base to Local

* output:local:fix parse_path

* remove path_info

* test:local versus base abs2relpath

* test:fix remaining abs2relpath test

* output: local path relative to wdir

* output: local: modify path before inheritance

* output: local: minor inheritance fix

* test: local: split output test

* test: local: positively explicit
@weekly-digest weekly-digest bot mentioned this issue Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
bug Did we break something? enhancement Enhances DVC good first issue p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add: auto convert absolute_path => relative casperdcl/dvc
2 participants
@efiop @casperdcl