Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: azure: test_open is failing on azure-storage-blob > 1.5.0 #2387

Closed
efiop opened this issue Aug 11, 2019 · 1 comment
Closed

test: azure: test_open is failing on azure-storage-blob > 1.5.0 #2387

efiop opened this issue Aug 11, 2019 · 1 comment
Assignees
@efiop
Labels
awaiting response we are waiting for your reply, please respond! :) p3-nice-to-have It should be done this or next sprint

Comments

@efiop
Copy link
Contributor

efiop commented Aug 11, 2019 •
edited
Loading

See https://travis-ci.com/iterative/dvc/jobs/224085273 .

It turnes out that azure python sdk modified the way they are calculating sas token in Azure/azure-storage-python@a79f8d8#diff-6ded9db46a5b567ba052e1e9d3c16acd (by adding KEY_VERSION and friends) and so now stringToSign computed in azurite https://github.com/Azure/Azurite/blob/v3.1.2-preview/src/blob/authentication/IBlobSASSignatureValues.ts#L168 doesn't match the one in https://github.com/Azure/azure-storage-python/blob/master/azure-storage-blob/azure/storage/blob/sharedaccesssignature.py#L226 . I will report this to azurite guys, but for now we could simply use 1.5.0 for our tests. We can't move to 1.5.0 permanently, because things like our conda package need 2.1.0.

For the record, this issue wasn't caught while #2371 was tested on CI because we still don't run those tests on regular PRs (we run them only on master) and the author used an old azure python sdk while testing it on his machine.

EDIT: Azure/Azurite#250
@efiop efiop added the p0-critical Critical issue. Needs to be fixed ASAP. label Aug 11, 2019
@efiop efiop self-assigned this Aug 11, 2019
efiop added a commit to efiop/dvc that referenced this issue Aug 11, 2019
@efiop
travis: use azurite v3
2f30bdd 
Trying to fix azure error on our ci:

https://travis-ci.com/iterative/dvc/jobs/224085273

Workaround for iterative#2387

Signed-off-by: Ruslan Kuprieiev <[email protected]>
@efiop efiop added p4-not-important and removed p0-critical Critical issue. Needs to be fixed ASAP. labels Aug 13, 2019
@efiop efiop added p3-nice-to-have It should be done this or next sprint awaiting response we are waiting for your reply, please respond! :) and removed p4 labels Sep 25, 2019
efiop added a commit to efiop/dvc that referenced this issue Nov 13, 2019
@efiop
test: try using azurite 3.3.0-preview
e4c3dbf 
Azurite was updated [2] to support new SAS tokens, so we no longer need
to downgrade azure-storage-blob for our tests.

[1] iterative#2387
[2] Azure/Azurite#250
@efiop efiop mentioned this issue Nov 13, 2019
Merged
3 tasks
@efiop
Copy link
Contributor Author

efiop commented Nov 13, 2019

Fixed by #2785

@efiop efiop closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
awaiting response we are waiting for your reply, please respond! :) p3-nice-to-have It should be done this or next sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@efiop