Skip to content

Commit

Permalink
RepoDependency: never changed (#4209)
Browse files Browse the repository at this point in the history
  • Loading branch information
pared authored Jul 16, 2020
1 parent 625b208 commit e4dafb8
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
6 changes: 6 additions & 0 deletions dvc/dependency/repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,9 @@ def update(self, rev=None):

with self._make_repo(locked=False) as repo:
self.def_repo[self.PARAM_REV_LOCK] = repo.get_rev()

def changed_checksum(self):
# From current repo point of view what describes RepoDependency is its
# origin project url and rev_lock, and it makes RepoDependency
# immutable, hence its impossible for checksum to change.
return False
4 changes: 3 additions & 1 deletion dvc/tree/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,9 @@ def is_dir_hash(cls, hash_):
return hash_.endswith(cls.CHECKSUM_DIR_SUFFIX)

def get_hash(self, path_info, tree=None, **kwargs):
assert isinstance(path_info, str) or path_info.scheme == self.scheme
assert path_info and (
isinstance(path_info, str) or path_info.scheme == self.scheme
)

if not tree:
tree = self
Expand Down
12 changes: 12 additions & 0 deletions tests/func/test_commit.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from os import fspath

import pytest

from dvc.dvcfile import PIPELINE_FILE
Expand Down Expand Up @@ -95,3 +97,13 @@ def test_commit_pipeline_stage(tmp_dir, dvc, run_copy):
assert dvc.commit(f":{stage.addressing}") == [stage]
assert dvc.commit(f"{PIPELINE_FILE}:{stage.addressing}") == [stage]
assert dvc.commit(PIPELINE_FILE) == [stage]


def test_imported_entries_unchanged(tmp_dir, dvc, erepo_dir):
with erepo_dir.chdir():
erepo_dir.dvc_gen("file", "file content", "initial commit")

stage = dvc.imp(fspath(erepo_dir), "file")

with dvc.state:
assert stage.changed_entries() == ([], [], None)

0 comments on commit e4dafb8

Please sign in to comment.