various review fixes

- minor comment as per #2546 (comment) - revert warning style fix #2546 (comment) - Abstract error consistency #2546 (comment) - minor comment as per #2546 (comment)
iterative · Oct 23, 2019 · bfaecf3 · bfaecf3
1 parent 614a9b1
commit bfaecf3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/dvc/command/add.py b/dvc/command/add.py
@@ -32,13 +32,13 @@ def run(self):
 
 
 def add_parser(subparsers, parent_parser):
-    add_help = "Track data files or directories with DVC."
+    ADD_HELP = "Track data files or directories with DVC."
 
     parser = subparsers.add_parser(
         "add",
         parents=[parent_parser],
-        description=append_doc_link(add_help, "add"),
-        help=add_help,
+        description=append_doc_link(ADD_HELP, "add"),
+        help=ADD_HELP,
         formatter_class=argparse.RawDescriptionHelpFormatter,
     )
     parser.add_argument(

diff --git a/dvc/command/base.py b/dvc/command/base.py
@@ -57,7 +57,7 @@ def default_targets(self):
 
     # Abstract methods that have to be implemented by any inheritance class
     def run(self):
-        raise NotImplementedError("Abstract")
+        raise NotImplementedError
 
 
 class CmdBaseNoRepo(CmdBase):

diff --git a/dvc/repo/add.py b/dvc/repo/add.py
@@ -64,6 +64,7 @@ def add(
                 stage.dump()
 
             stages_list += stages
+        # remove filled bar bit of progress, leaving stats
         pbar.bar_format = pbar.BAR_FMT_DEFAULT.replace("|{bar:10}|", " ")
 
     return stages_list