Skip to content

Commit

Permalink
tests: remove redundant native ssh tests
Browse files Browse the repository at this point in the history
We already have mocked ones, which are more reliable as they use their
own paramiko server instead of relying on the sshd running on the test
machine. Native tests are also quite flaky and fail sometimes due to
network issues.
  • Loading branch information
efiop committed Jan 11, 2020
1 parent 0110358 commit 8154c89
Showing 1 changed file with 0 additions and 25 deletions.
25 changes: 0 additions & 25 deletions tests/func/test_data_cloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
from tests.remotes import (
_should_test_gcp,
_should_test_hdfs,
_should_test_ssh,
Azure,
GDrive,
S3,
Expand All @@ -47,7 +46,6 @@
get_gcp_url,
get_hdfs_url,
get_local_url,
get_ssh_url,
get_ssh_url_mocked,
)

Expand Down Expand Up @@ -296,17 +294,6 @@ def test(self):
self.assertTrue(os.path.isdir(self.dname))


class TestRemoteSSH(TestDataCloudBase):
def _should_test(self):
return _should_test_ssh()

def _get_url(self):
return get_ssh_url()

def _get_cloud_class(self):
return RemoteSSH


@pytest.mark.usefixtures("ssh_server")
class TestRemoteSSHMocked(TestDataCloudBase):
@pytest.fixture(autouse=True)
Expand Down Expand Up @@ -442,18 +429,6 @@ def _test(self):
self._test_cloud(TEST_REMOTE)


class TestRemoteSSHCLI(TestDataCloudCLIBase):
def _should_test(self):
return _should_test_ssh()

def _test(self):
url = get_ssh_url()

self.main(["remote", "add", TEST_REMOTE, url])

self._test_cloud(TEST_REMOTE)


class TestRemoteHDFSCLI(TestDataCloudCLIBase):
def _should_test(self):
return _should_test_hdfs()
Expand Down

0 comments on commit 8154c89

Please sign in to comment.