keep stage.dump and dvcfile.dump in sync (#5382)

iterative · Feb 2, 2021 · 4348832 · 4348832
1 parent d05be36
commit 4348832
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dvc/command/stage.py b/dvc/command/stage.py
@@ -135,7 +135,7 @@ def run(self):
 
         with repo.scm.track_file_changes(config=repo.config):
             stage.ignore_outs()
-            stage.dump()
+            stage.dump(update_lock=False)
         return 0
 
 

diff --git a/dvc/stage/__init__.py b/dvc/stage/__init__.py
@@ -701,8 +701,8 @@ def merge(self, ancestor, other):
 
         self.outs[0].merge(ancestor_out, other.outs[0])
 
-    def dump(self, update_lock: bool = False):
-        self.dvcfile.dump(self, update_lock=update_lock)
+    def dump(self, **kwargs):
+        self.dvcfile.dump(self, **kwargs)
 
 
 class PipelineStage(Stage):

diff --git a/tests/unit/test_params.py b/tests/unit/test_params.py
@@ -27,7 +27,7 @@ def test_repro_unicode(tmp_dir, dvc, dummy_stage):
     dummy_stage(params=[{"settings.json": ["Ω_value"]}])
     (stage,) = dvc.reproduce(dry=True)
     stage.cmd = "foo"
-    stage.dvcfile._lockfile.dump(stage)
+    stage.dump()
 
     dvc.remove(stage.name)
     assert not (tmp_dir / "dvc.yaml").exists()