Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom collapse in sidemenu #991

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

iAdramelk
Copy link
Contributor

As part of community page I updated react-collapse to version 5.0 and it so happens this version can be also used in side menu and is fixing some of our existing issues.

Fix #856
Fix #724

@shcheklein shcheklein temporarily deployed to dvc-landing-fix-collaps-uupn0u February 13, 2020 15:45 Inactive
@shcheklein
Copy link
Member

This looks awesome!

@shcheklein
Copy link
Member

@fabiosantoscode could you review this please?

Copy link
Contributor

@fabiosantoscode fabiosantoscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good. 👍

@shcheklein shcheklein merged commit a94e7cc into master Feb 13, 2020
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nav: left sidebar isn't visible without js nav: unnecessary gaps in sidebar
4 participants